Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y] Removing !important from letter-spacing marketing typography #2613

Merged
merged 2 commits into from
May 7, 2024

Conversation

stamat
Copy link
Contributor

@stamat stamat commented Apr 24, 2024

What are you trying to accomplish?

Hello there! 👋

We've got like "trillion" accessibility issues for not allowing letter spacing change by the assistive plugins on dotcom marketing pages. So I would really like to solve these and remove !important on letter spacing. 🙏

I've created an override only for the /marketing/type/typography.scss file on dotcom https://github.com/github/github/pull/322450 :

  1. Firstly to prove that nothing will be broken - nothing is at first glance, all other utilities with letter spacign work, order of class placement seems about right to not need !important.
  2. Secondly to use as a temporary solution - but I don't really want ot use the override since it's not managable.

The only concern is that the users that might use the mktg styles might get impacted, but i think that Impact is minor, if not nonexiting.

That's about it. Do help me merge/deploy this 🙏 ❤️

Can these changes ship as is?

  • Yes, this PR does not depend on additional changes. 🚢

Copy link

changeset-bot bot commented Apr 24, 2024

🦋 Changeset detected

Latest commit: 04265f8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@stamat stamat changed the title removing !important from letter-spacing marketing typography [a11y] Removing !important from letter-spacing marketing typography Apr 24, 2024
@stamat stamat self-assigned this Apr 24, 2024
@stamat stamat marked this pull request as ready for review April 24, 2024 14:00
@stamat stamat requested a review from a team as a code owner April 24, 2024 14:01
@stamat
Copy link
Contributor Author

stamat commented May 7, 2024

@langermank hey hey, when do you think this patch can be released? Just curious! 🙏 Thanks legend!

@langermank langermank merged commit 2eabfde into main May 7, 2024
11 of 12 checks passed
@langermank langermank deleted the stamat/marketing-letter-spacing-not-important branch May 7, 2024 14:18
@primer primer bot mentioned this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants