Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Major] Remove legacy color support #2607

Closed
wants to merge 9 commits into from
Closed

Conversation

langermank
Copy link
Contributor

@langermank langermank commented Apr 9, 2024

This PR removes support for color themes. Going forward, Primer expects an explicit color theme import directly from primer/primitives.

@import '@primer/primitives/dist/css/functional/themes/light.css';
@import '@primer/primitives/dist/css/functional/themes/light-tritanopia.css';
@import '@primer/primitives/dist/css/functional/themes/light-high-contrast.css';
@import '@primer/primitives/dist/css/functional/themes/light-colorblind.css';
@import '@primer/primitives/dist/css/functional/themes/dark.css';
@import '@primer/primitives/dist/css/functional/themes/dark-colorblind.css';
@import '@primer/primitives/dist/css/functional/themes/dark-dimmed.css';
@import '@primer/primitives/dist/css/functional/themes/dark-high-contrast.css';
@import '@primer/primitives/dist/css/functional/themes/dark-tritanopia.css';

This is a breaking change and marked as such.

Copy link

changeset-bot bot commented Apr 9, 2024

🦋 Changeset detected

Latest commit: 77ef79f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@include color-mode-theme(dark) {
@include primer-colors-dark;
}
@import '@primer/primitives/dist/css/functional/themes/dark.css';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're gonna go with a major, I say we just completely remove the src/color-modes/ folder and use the primitives imports directly in dotcom

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@github-actions github-actions bot temporarily deployed to Storybook Preview May 10, 2024 17:45 Inactive
@langermank langermank changed the title [Draft] next major [Major] Remove legacy color support May 16, 2024
@langermank langermank marked this pull request as ready for review May 16, 2024 21:32
@langermank langermank requested review from a team as code owners May 16, 2024 21:32
@langermank langermank requested a review from mperrotti May 16, 2024 21:32
Copy link
Contributor

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

@github-actions github-actions bot added the Stale Automatically marked as stale. label Oct 11, 2024
@github-actions github-actions bot closed this Oct 18, 2024
@github-actions github-actions bot deleted the remove-old-colors branch October 18, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major release Stale Automatically marked as stale.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants