Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace remote GitHub avatars with local assets #822

Merged
merged 10 commits into from
Nov 19, 2024

Conversation

joshfarrant
Copy link
Contributor

Summary

What should reviewers focus on?

  • Check I've not missed any instances of remote GitHub avatars
  • Check that nothing has changed visually in the docs or Storybook

Steps to test:

Supporting resources (related issues, external links, etc):

Contributor checklist:

  • All new and existing CI checks pass
  • Tests prove that the feature works and covers both happy and unhappy paths
  • Any drop in coverage, breaking changes or regressions have been documented above
  • UI Changes contain new visual snapshots (generated by adding update snapshots label to the PR)
  • All developer debugging and non-functional logging has been removed
  • Related issues have been referenced in the PR description

Reviewer checklist:

  • Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
  • Check that tests prove the feature works and covers both happy and unhappy paths
  • Check that there aren't other open Pull Requests for the same update/change

Copy link

changeset-bot bot commented Nov 18, 2024

🦋 Changeset detected

Latest commit: b0450d3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@primer/react-brand Patch
@primer/brand-primitives Patch
@primer/brand-e2e Patch
@primer/brand-fonts Patch
@primer/brand-config Patch
@primer/brand-storybook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 18, 2024

🟢 No design token changes found

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 10 changed files in this pull request and generated no suggestions.

Files not reviewed (3)
  • apps/docs/content/components/Avatar/react.mdx: Language not supported
  • apps/docs/content/components/IDE.mdx: Language not supported
  • apps/docs/content/components/Testimonial/react.mdx: Language not supported

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more

@joshfarrant joshfarrant changed the title Joshfarrant/mona image Replace remote GitHub avatars with local assets Nov 18, 2024
Copy link
Contributor

github-actions bot commented Nov 18, 2024

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

Copy link
Contributor

@danielguillan danielguillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

Comment on lines 141 to 146
type IDEChatMessageAssistant = {
role: 'assistant'
handle: string
message: string
codeSnippet?: string
highlighter?: 'hljs'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit... this seems a little duplicative. Took me a second to spot the difference . Worth creating an intersection with a shared message type for handle, message, codeSnippet and highlighter?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, updated 🙂

}

export type IDEChatMessage = IDEChatMessageUser | IDEChatMessageAssistant
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need a changeset for this update as it's a material change to the library. Although, it doesn't need to say too much.

Maybe something like: Updated IDEChatMessage type declaration to differentiate between assistant and user messages. WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good shout, added 👍

Copy link
Collaborator

@rezrah rezrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joshfarrant. Left a comment about a missing changeset, but otherwise LGTM. Will pre-emptively ✅ so you can merge in when ready.

@joshfarrant
Copy link
Contributor Author

Thanks @rezrah 🙌

Just made those changes, will merge once the checks have finished :shipit:

@joshfarrant joshfarrant merged commit 75da350 into main Nov 19, 2024
18 checks passed
@joshfarrant joshfarrant deleted the joshfarrant/mona-image branch November 19, 2024 11:55
@primer-css primer-css mentioned this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants