-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace remote GitHub avatars with local assets #822
Conversation
🦋 Changeset detectedLatest commit: b0450d3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🟢 No design token changes found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 7 out of 10 changed files in this pull request and generated no suggestions.
Files not reviewed (3)
- apps/docs/content/components/Avatar/react.mdx: Language not supported
- apps/docs/content/components/IDE.mdx: Language not supported
- apps/docs/content/components/Testimonial/react.mdx: Language not supported
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
🟢 No visual differences foundOur visual comparison tests did not find any differences in the UI. |
89b0b8b
to
2621fd9
Compare
2621fd9
to
1bd9248
Compare
1bd9248
to
b6c9bb9
Compare
b6c9bb9
to
8e7a2ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this!
packages/react/src/IDE/IDE.tsx
Outdated
type IDEChatMessageAssistant = { | ||
role: 'assistant' | ||
handle: string | ||
message: string | ||
codeSnippet?: string | ||
highlighter?: 'hljs' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit... this seems a little duplicative. Took me a second to spot the difference . Worth creating an intersection with a shared message type for handle
, message
, codeSnippet
and highlighter
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me, updated 🙂
packages/react/src/IDE/IDE.tsx
Outdated
} | ||
|
||
export type IDEChatMessage = IDEChatMessageUser | IDEChatMessageAssistant |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need a changeset for this update as it's a material change to the library. Although, it doesn't need to say too much.
Maybe something like: Updated IDEChatMessage
type declaration to differentiate between assistant and user messages. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good shout, added 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @joshfarrant. Left a comment about a missing changeset, but otherwise LGTM. Will pre-emptively ✅ so you can merge in when ready.
Thanks @rezrah 🙌 Just made those changes, will merge once the checks have finished |
Summary
IDE
component to remove unusedavatar
property from assistant message typeWhat should reviewers focus on?
Steps to test:
Supporting resources (related issues, external links, etc):
Contributor checklist:
update snapshots
label to the PR)Reviewer checklist: