Add IterateFocusableElements options to focusZone #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 00478de The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
pksjce
reviewed
Oct 23, 2023
| <button>Peach</button> | ||
| </div> | ||
| </div> | ||
| <button tabIndex={-1}>Cantaloupe</button> |
There was a problem hiding this comment.
Maybe I'm missing something. Doesn't this make it non focusable with keyboard? How does this button have a place in the focusable array?
There was a problem hiding this comment.
The iterateFocusableElements will return "any element with tabindex explicitly set can be focusable, even if it's set to "-1"" if onlyTabbable option is false
pksjce
approved these changes
Oct 23, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
We ran into a bug when using
useFocusZonein our component where when the css visibility is set to "hidden" the user is unable to tab past the element. I noticediterateFocusableElementshas astrictoption that checks for elements with hidden visibility butuseFocusZonedoes not support thestrictargument to be passed through toiterateFocusableElements. We would like to enable strict mode inuseFocusZoneto removevisibility: hiddenelements as focusable elements.More details on the bug: https://github.com/github/issues/issues/7911
What are you trying to accomplish?
Add ability in focus zone to pass through settings options to
iterateFocusableElements. Also, I added an additional check to not focus on elements that have "display: none" on the element and its parents