feat: make the audit role template_url configurable #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonZeolla
commented
Jul 19, 2024
| @@ -28,6 +28,7 @@ organization = { | |||
| disable_sso_management = false | |||
| deploy_audit_role = true | |||
| audit_role_name = "security-audit" | |||
| audit_role_template_url = "https://s3.amazonaws.com/pht-cloudformation/aws-account-automation/AuditRole-Template.yaml" | |||
There was a problem hiding this comment.
Even though it's not required, I figured it would still be a good idea to highlight that it's configurable in the example here; I'd be good removing it and using the default if you prefer.
JonZeolla
commented
Jul 21, 2024
| @@ -112,8 +112,7 @@ organization = { | |||
| phone_number = "+14041234567" | |||
| } | |||
|
|
|||
| organization_units = { | |||
|
|
|||
| organizational_units = { | |||
There was a problem hiding this comment.
It seemed to make sense to rename this
JonZeolla
commented
Jul 21, 2024
| @@ -85,7 +83,7 @@ git submodule add https://github.com/primeharbor/pht-account-configurator | |||
| git submodule init | |||
| git submodule update | |||
|
|
|||
| EOF | |||
| <!--EOF | |||
There was a problem hiding this comment.
Since the below seemed to be a note to self, I figured not rendering it would make sense. Up to you
JonZeolla
commented
Jul 25, 2024
| @@ -21,8 +21,6 @@ else | |||
| REPO=github.com/primeharbor/org-kickstart//modules/security_services?ref=$VERSION | |||
| fi | |||
|
|
|||
| REPO=/Users/chris/AWS/org-kickstart/modules/security_services | |||
There was a problem hiding this comment.
I assume this was an unintentional leave-behind from troubleshooting or maybe bootstrapping the project
JonZeolla
commented
Jul 26, 2024
| ./scripts/import-org.sh | ||
| ./scripts/import_org.sh |
JonZeolla
commented
Jul 29, 2024
| 2. Comment out the `service_control_policies = {}` block | ||
| 3. We will re-enable them after the first apply. | ||
| 4. Delete the `security_services.tf` file on the first run. | ||
| 1. **IMPORTANT**: Ensure that your `payer_name` and `payer_email` variables align with what you manually used when creating the first AWS account, otherwise |
There was a problem hiding this comment.
I feel like the importance of this one can't be understated; perhaps break it out to be even more obvious?
JonZeolla
commented
Jul 31, 2024
Comment on lines
-59
to
+58
| parent_ou_id = "ou-yyyy-yyyyyyyy" | ||
| parent_ou_id = "Sandbox" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.