DefineComponent instead of class to improve type-checking #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm searching using
$emittypes library, and I found that this library define lot of events in some single component.If define component types as class, IDE can't infer args types because typescript limit, please see: vuejs/language-tools#60
A solution is use DefineComponent instead of class, volar already supported emit SFC (
.vue) to typescript declaration (.d.ts).In this repo you need a
jsconfig.jsonto tell volar pickup vue files, and than you can useVolar: Emit TypeScript declaration filecommand to emit typescript declaration. please take a consider.