fix: Slider: "Unable to preventDefault inside passive event listener invocation" in primevue_slider.js (touchmove) #6537
+0
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The event.preventDefault() method has been removed. The touch event uses the .passive modifier, and also uses the preventDefault method. On mobile devices, the browser will report an error. The official documentation for Vue.js is as follows: https://vuejs.org/guide/essentials/event-handling.html#event-modifiers Do not use .passive and .prevent together, because .passive already indicates to the browser that you do not intend to prevent the event's default behavior, and you will likely see a warning from the browser if you do so.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
|
Please create an issue while sending PR. |
tugcekucukoglu
added
the
Resolution: Needs Revision
caryhgq
changed the title
tugcekucukoglu
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #5745.
The event.preventDefault() method has been removed.
The touch event uses the .passive modifier, and also uses the preventDefault method. On mobile devices, the browser will report an error.
The official documentation for Vue.js is as follows:
https://vuejs.org/guide/essentials/event-handling.html#event-modifiers
Do not use .passive and .prevent together, because .passive already indicates to the browser that you do not intend to prevent the event's default behavior, and you will likely see a warning from the browser if you do so.
###Defect Fixes
When submitting a PR, please also create an issue documenting the error.
###Feature Requests
Due to company policy, we are unable to accept feature request PRs with significant changes as such cases has to be implemented by our team following our own processes.