Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#6303 fix: Multiselect - correctly default to locale when selectedItemsLabel… #6414

Merged
merged 2 commits into from
Sep 24, 2024
Merged

#6303 fix: Multiselect - correctly default to locale when selectedItemsLabel… #6414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46452f6
fix: Multiselect - correctly default to locale when selectedItemsLabe…
avramz Sep 16, 2024
30fd8ad
Merge branch 'primefaces:master' into fix/multiselect-selection-messa…
avramz Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/showcase/doc/common/apidoc/index.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40657,7 +40657,7 @@
"readonly": false,
"type": "string",
"default": "'{0} items selected'",
"description": "Label to display after exceeding max selected labels."
"description": "Label to display after exceeding max selected labels. Defaults to value from PrimeVue locale configuration."
},
{
"name": "maxSelectedLabels",
Expand Down Expand Up @@ -95489,4 +95489,4 @@
}
}
}
}
}
2 changes: 1 addition & 1 deletion packages/primevue/scripts/components/multiselect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ const MultiSelectProps = [
name: 'selectedItemsLabel',
type: 'string',
default: '{0} items selected',
description: 'Label to display after exceeding max selected labels.'
description: 'Label to display after exceeding max selected labels. Defaults to value from PrimeVue locale configuration.'
},
{
name: 'maxSelectedLabels',
Expand Down
2 changes: 1 addition & 1 deletion packages/primevue/src/multiselect/BaseMultiSelect.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export default {
},
selectedItemsLabel: {
type: String,
default: '{0} items selected'
default: null
},
maxSelectedLabels: {
type: Number,
Expand Down
4 changes: 2 additions & 2 deletions packages/primevue/src/multiselect/MultiSelect.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,7 @@ export interface MultiSelectProps {
display?: 'comma' | 'chip' | undefined;
/**
* Label to display after exceeding max selected labels.
* @defaultValue '{0} items selected'
* @defaultValue 'null'
*/
selectedItemsLabel?: string | undefined;
/**
Expand Down Expand Up @@ -524,7 +524,7 @@ export interface MultiSelectProps {
filterMessage?: string | undefined;
/**
* Text to be displayed in hidden accessible field when options are selected. Defaults to value from PrimeVue locale configuration.
* @defaultValue '{0} items selected'
* @defaultValue 'null'
*/
selectionMessage?: string | undefined;
/**
Expand Down
Loading