#6233 - Listbox: Preserve option groups while filtering. #6275
Conversation
chore: Add unit tests fixes primefaces#6233
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
tugcekucukoglu
added
the
Resolution: Needs Revision
| const groupChildren = this.getOptionGroupChildren(group); | ||
| const filteredItems = groupChildren.filter((item) => filteredOptions.includes(item)); | ||
|
|
||
| if (filteredItems.length > 0) filtered.push({ ...group, [typeof this.optionGroupChildren === 'string' ? this.optionGroupChildren : 'items']: [...filteredItems] }); |
There was a problem hiding this comment.
What about typeof this.optionGroupChildren is not 'string'? It seems it returns 'items'.
There was a problem hiding this comment.
items is a fallback - this method is the same as in MultiSelect -> https://github.com/primefaces/primevue/blob/master/packages/primevue/src/multiselect/MultiSelect.vue#L1012
and Select -> https://github.com/primefaces/primevue/blob/master/packages/primevue/src/select/Select.vue#L926
They both deal with the same data structure and I didn't want to reimplement the logic for consistency.
If the filtering logic for Listbox still needs to be changed I suggest that Select/MultiSelect is updated too, as they deal with the same data structures. What do you think?
There was a problem hiding this comment.
As I said before, it is not correct to return a string here. We are open to new solutions.
There was a problem hiding this comment.
Updated the PR with optimized visibleOptions rendering logic.
There was a problem hiding this comment.
@tugcekucukoglu any feedback?
tugcekucukoglu
removed
the
Resolution: Needs Revision
fix: Listbox: Preserve option groups while filtering.
chore: Add unit tests
###Defect Fixes
fixes #6233