fix: use units in select label padding calculation #5848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addition in css' `calc` function [requires both operands to be `<length>`](https://css-tricks.com/a-complete-guide-to-calc-in-css/#aa-addition-and-subtraction-require-both-numbers-to-be-lengths)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
|
Here's more documentation: https://developer.mozilla.org/en-US/docs/Web/CSS/calc
I know the documentation talks about the number zero specifically. However, I believe that it is clear that no number can be used in this way. |
SoyDiego
approved these changes
Jun 12, 2024
|
Good catch! Thanks a lot for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition in css'
calcfunction requires both operands to be<length>. Using invalid value (<number>in this case) causes the calculation to fail and padding is not applied at all:Using valid value (
1rem) fixes the issue and padding is inserted as expected:Fixes
This PR fixes #5847.