fix Calendar value typings #3517
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing typings for open date ranges. These are necessary when you are using the calendar to select a date range. One end of the range may not be chosen yet. This adds the typing for a fixed size array of size 2. Optionally, to simplify the code, we can define it separately (this is how I have it in my code): ```typescript type OpenDateRange = [Date | null | undefined, Date | null | undefined]; type CalendarValueType = string | Date | string[] | Date[] | OpenDateRange | undefined; ``` Alternatively, `OpenDateRange` could be defined as `(Date | null | undefined )[]`
|
The team has decided not to use type. Please check #3696 In this circumstances closing the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing typings for open date ranges. These are necessary when you are using the calendar to select a date range. One end of the range may not be chosen yet. This adds the typing for a fixed size array of size 2.
Optionally, to simplify the code, we can define it separately (this is how I have it in my code):
Alternatively,
OpenDateRangecould be defined as(Date | null | undefined )[]Fixes #3521
###Feature Requests
Due to company policy, we are unable to accept feature request PRs with significant changes as such cases has to be implemented by our team following our own processes.