Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scoped style (dt props) does not attach to page with correct selector #6408

Closed
mertsincan opened this issue Sep 16, 2024 · 1 comment
Closed

Scoped style (dt props) does not attach to page with correct selector #6408

mertsincan opened this issue Sep 16, 2024 · 1 comment
Assignees
@mertsincan
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
4.1.0

Comments

@mertsincan
Copy link
Member

The attribute selector is generated differently on the server and client.
@mertsincan mertsincan added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Sep 16, 2024
@mertsincan mertsincan self-assigned this Sep 16, 2024
@mertsincan mertsincan added this to the 4.0.8 milestone Sep 16, 2024
mertsincan added a commit that referenced this issue Sep 16, 2024
@mertsincan
Refactor #6408
827787f
@cagataycivici cagataycivici modified the milestones: 4.0.8, 4.1.0 Sep 17, 2024
mertsincan added a commit that referenced this issue Sep 24, 2024
@mertsincan
Refactor #6408
32c6c77
@Sherl0ck007
Copy link

After the change in this commit, the pc{number} attributes in snapshots are not consistent. The change on every run of the unit test. This causes snapshot tests to fail because of a mismatch in either the property name or the order of html props in the snapshots.
When you update the failing snapshots, the match during the very next run. The run after, they fail again because of a mismatch.
Please consider re-opening this issue to address the problem it is causing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mertsincan mertsincan

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
4.1.0
Development

No branches or pull requests
3 participants
@cagataycivici @mertsincan @Sherl0ck007