Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Upload: Basic mode breaks all file selections after initial selection #6257

Closed
m-meier opened this issue Aug 19, 2024 · 0 comments · Fixed by twin-tigon/hypermodern-python-talk#4 · May be fixed by nerds-github/litlyx#11
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@m-meier
Copy link
Contributor

m-meier commented Aug 19, 2024

Describe the bug

In basic mode there are initial steps of transforming the choose button to an upload button, however the change is incomplete. This leads to the problem that after the initial selection the choose buttons becomes inactive onBasicUploaderClick only opens the choose file dialog if no files have been selected so far. Additionally the hidden file input element is removed due to an v-if="!hasFiles".

Reproducer

https://stackblitz.com/edit/primevue-4-vite-issue-template-5hc4ym?file=src%2FApp.vue

PrimeVue version

4.0.4

Vue version

4.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

  1. Select a file
  2. Try to select another file

Expected behavior

No response

@m-meier m-meier added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 19, 2024
m-meier pushed a commit to m-meier/primevue that referenced this issue Aug 19, 2024
…aces#6257, primefaces#5748

This fix removes the initial code for a transformation to an upload button
since the code is incomplete. It also removes the bug that you cannot
perform additional file selections.
tugcekucukoglu added a commit that referenced this issue Aug 21, 2024
fix(FileUpload): fix broken choose button in basic mode, fixes #6257,…
LeaderbotX400 pushed a commit to LeaderbotX400/primevue that referenced this issue Aug 29, 2024
…aces#6257, primefaces#5748

This fix removes the initial code for a transformation to an upload button
since the code is incomplete. It also removes the bug that you cannot
perform additional file selections.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
1 participant