Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Knob: Wrong Source Code in Documentation #5281

Closed
amal-qb opened this issue Feb 15, 2024 · 0 comments · Fixed by qburst/primevue-2#2 or #5282
Closed

Knob: Wrong Source Code in Documentation #5281

amal-qb opened this issue Feb 15, 2024 · 0 comments · Fixed by qburst/primevue-2#2 or #5282
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@amal-qb
Copy link
Contributor

amal-qb commented Feb 15, 2024

Describe the bug

The source code for the Min/Max Knob section is wrong. i.e. the :max value:

image

Reproducer

https://primevue.org/knob/#minmax

PrimeVue version

3.48.1

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

  1. Go to https://primevue.org/knob/#minmax and check the source code of the example.

Expected behavior

The source code should be correct.
@amal-qb amal-qb added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 15, 2024
amal-qb pushed a commit to qburst/primevue-2 that referenced this issue Feb 15, 2024
primefaces#5281: Fix min max source code
49be8d9
@amal-qb amal-qb mentioned this issue Feb 15, 2024
Merged
amal-qb added a commit to qburst/primevue-2 that referenced this issue Feb 15, 2024
@amal-qb
Merge pull request #2 from qburst/primefaces#5281-knob-min-max-code
4451594 
primefaces#5281: Fix Knob Min/Max Source Code
@amal-qb amal-qb mentioned this issue Feb 15, 2024
Merged
@amal-qb amal-qb reopened this Feb 15, 2024
tugcekucukoglu added a commit that referenced this issue Feb 15, 2024
@tugcekucukoglu
Merge pull request #5282 from qburst/master
ae4aba2 
Fix #5281 - Knob Min/Max Source Code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Milestone
No milestone
1 participant
@amal-qb