Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

locale "selectedItemsLabel" is broken on MultiSelect #4558

Closed
petitkriket opened this issue Oct 5, 2023 · 0 comments · Fixed by #4588
Closed

locale "selectedItemsLabel" is broken on MultiSelect #4558

petitkriket opened this issue Oct 5, 2023 · 0 comments · Fixed by #4588
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@petitkriket
Copy link

petitkriket commented Oct 5, 2023

Describe the bug

Hello,

Description of the issue

The mapping between MultiSelect selectedItemsLabel text and the global locale registration app configuration is broken
(selectionMessage)

minor: locale documentation page lack of a proper and fonctionnal example (would love to create one for you), as it could help to have a working stackblitz/codesandbox example with primevue (like for the components documentation)

Here is a basic reproduction

Context:

  • it does not work by using global locale registration in main.ts for this specific message
  • it works for every other messages of the same components
  • it works by using the component prop directly (local override)
  • the computed responsible for this shows no issue component code

Additionnal

Here is the issue related to primefaces/primelocale that I closed because it seem to be primevue related only

Reproducer

https://stackblitz.com/edit/ejwndf?file=src%2FApp.vue,src%2Fmain.js%3AL120-L120

Screenshot 2023-10-05 at 16 21 46

PrimeVue version

3.35.0

Vue version

3.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

register a community locale (or any self writted one)
see how it is actually ignored by the component that should consume it (here a MultiSelect)

Expected behavior

global app wide locale registration should work when defined into main.ts

@petitkriket petitkriket added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 5, 2023
@petitkriket petitkriket changed the title community locales support is broken / undocumented (MultiSelect) locale support is broken / undocumented (MultiSelect) Oct 5, 2023
@petitkriket petitkriket changed the title locale support is broken / undocumented (MultiSelect) locale "selectedItemsLabel" is broken on MultiSelect Oct 5, 2023
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Oct 5, 2023
chz added a commit to chz/primevue that referenced this issue Oct 10, 2023
chz added a commit to chz/primevue that referenced this issue Oct 10, 2023
@tugcekucukoglu tugcekucukoglu added this to the 3.37.0 milestone Oct 17, 2023
tugcekucukoglu added a commit that referenced this issue Oct 17, 2023
Fix #4558 - locale "selectedItemsLabel" is broken on MultiSelect
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants