You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is not really the issue I was reporting. Draggable is failing if their is a Tab View in the Dialog. It seems to have started in 3.30.0. A reproducer is here. https://stackblitz.com/edit/o7cqoc-gmw8jq?file=package.json
Hi @caputech. You're right, there is really issue with dragging Dialog when TabView is inside it, but not only TabView. I found the same problem with other components. Today I'll investigate the reason for this bug and try to fix it. Happy codding!
You can try adding a title to the header and with the title you can drag the dialog only by clicking on the title text or close button. Implementation with header title
But it doesn't solve the problem.
I've figured out the reason for the bug. Inside the Dialog component, we have an initDrag method. Inside this method, we have the condition for checking if the element or its parent has 'data-pc-section' attribute with "headeraction" value. If the element meets this condition initDrag stops working and Dialog doesn't drag. We can solve this problem by deleting this condition from the initDrag method. But it could cause unexpected behavior in the Dialog.
@bahadirsofuoglu could you please check this solution cause you added this condition in commit. Won't it cause the unexpected behavior of the Dialog component?
I've created a pull request #4332 to fix this bug.
Thanks. I did notice that a header could be dragged. However, we use the header slot instead of the prop. And using that, it does not allow dragging via the header.
Originally posted by @caputech in #4298 (comment)
The text was updated successfully, but these errors were encountered: