Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog: Draggable STILL Fails #4298

Closed
caputech opened this issue Aug 18, 2023 · 4 comments · Fixed by #4314
Closed

Dialog: Draggable STILL Fails #4298

caputech opened this issue Aug 18, 2023 · 4 comments · Fixed by #4314
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@caputech
Copy link

caputech commented Aug 18, 2023

Describe the bug

Dialog Component: Draggable prop no longer works. Dialogs cannot be dragged since 3.30.0. The docs illustrate the behavior now.

Reproducer

https://codesandbox.io/p/sandbox/primevue-demo-forked-s7vhyc

PrimeVue version

3032.1

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

Attempt to drag a Dialog. Even explicitly setting draggable to true does not correct.

Expected behavior

Expect Dialog to be draggable when set or by default. The docs now also illustrate this behavior in 3.32.1.

@caputech caputech added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 18, 2023
@caputech caputech changed the title Component Name: Issue Title Dialog: Draggable Fails Aug 18, 2023
@reksc
Copy link

reksc commented Aug 21, 2023

In my case in 3.32.0 drag and drop works well, the breaking change is introduced in the latest 3.32.1.

Uncaught TypeError: getComputedStyle is not a function at HTMLDocument.documentDragListener (dialog.esm.js:436:34)

@melloware
Copy link
Member

melloware commented Aug 21, 2023

Introduced by: #4252

Cc @Dmytro-Lukashenko

@Dmytro-Lukashenko
Copy link
Contributor

Hi guys! I've fixed this bug. It was the incorrect naming of the variable. I've changed getComputedStyle to containerComputedStyle. @melloware could you please check it?

@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 23, 2023
@tugcekucukoglu tugcekucukoglu added this to the 3.32.2 milestone Aug 23, 2023
@caputech
Copy link
Author

This is not really the issue I was reporting. Draggable is failing if their is a Tab View in the Dialog. It seems to have started in 3.30.0. A reproducer is here. https://stackblitz.com/edit/o7cqoc-gmw8jq?file=package.json

@caputech caputech changed the title Dialog: Draggable Fails Dialog: Draggable STILL Fails Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants