Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown: Invalid slot typings #4263

Closed
Magiczne opened this issue Aug 13, 2023 · 0 comments
Closed

Dropdown: Invalid slot typings #4263

Magiczne opened this issue Aug 13, 2023 · 0 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@Magiczne
Copy link
Contributor

Magiczne commented Aug 13, 2023

Describe the bug

  1. onClick in the clearicon slot has invalid typing - function is typed as a void
  2. clearicon slot does not type the class slot props that is exposed.
  3. filtericon slot does not type the class slot props that is exposed.

Current typing:

clearicon(scope: {
  onClick: void;
}): VNode[];

filtericon(): VNode[];

Expected typing:

clearicon(scope: {
  class: string;
  onClick: () => void;
}): VNode[];

filtericon(scope: {
  class: string;
}): VNode[];

additionally the class slot props inside dropdownicona and loading icon should be typed as strings.

Reproducer

Dropdown.d.ts:565-594

PrimeVue version

4.32.0

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

@Magiczne Magiczne added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 13, 2023
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 15, 2023
@tugcekucukoglu tugcekucukoglu added this to the 3.32.1 milestone Aug 15, 2023
@tugcekucukoglu tugcekucukoglu self-assigned this Aug 15, 2023
tugcekucukoglu added a commit that referenced this issue Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants