Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename slots for toolbar #1761

Closed
cagataycivici opened this issue Nov 15, 2021 · 1 comment
Closed

Rename slots for toolbar #1761

cagataycivici opened this issue Nov 15, 2021 · 1 comment
Assignees
@cagataycivici
Labels
Type: Breaking Change Issue contains a breaking change related to a specific component
Milestone
3.9.1

Comments

@cagataycivici
Copy link
Member

Use start and end instead of left-right for convention.
@cagataycivici cagataycivici added the Type: Breaking Change Issue contains a breaking change related to a specific component label Nov 15, 2021
@cagataycivici cagataycivici added this to the 3.9.0 milestone Nov 15, 2021
@cagataycivici cagataycivici self-assigned this Nov 15, 2021
@cagataycivici cagataycivici modified the milestones: 3.9.0, 3.9.1 Nov 18, 2021
cagataycivici added a commit that referenced this issue Nov 18, 2021
@cagataycivici
Fixed #1761
cdf9652
@tugcekucukoglu tugcekucukoglu mentioned this issue Nov 22, 2021
Closed
@jonashao
Copy link

Slots declaration in Toolbar.d.ts is still left-right.

matmassa added a commit to KnowageLabs/Knowage-Server that referenced this issue Feb 4, 2022
@matmassa
Changed lib prime-vue and chart-js versions
6a82c0d 
primefaces/primevue#1761
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagataycivici cagataycivici

Labels
Type: Breaking Change Issue contains a breaking change related to a specific component
Projects
None yet
Milestone
3.9.1
Development

No branches or pull requests
2 participants
@cagataycivici @jonashao