Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar: Allow typing dates manually #4134

Closed
inad9300 opened this issue Mar 6, 2023 · 4 comments · Fixed by #6986
Closed

Calendar: Allow typing dates manually #4134

inad9300 opened this issue Mar 6, 2023 · 4 comments · Fixed by #6986
Assignees
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA
Milestone

Comments

@inad9300
Copy link
Contributor

inad9300 commented Mar 6, 2023

Describe the feature you would like to see added

As a user, I would like to be able to type dates using the keyboard, and not be forced to use the UI. A common case where this is necessary is having to type your birthday: using the UI would take lots and lots of clicks, while using the keyboard would be much more immediate.

Currently, the interaction with the calendar's input box is very cumbersome. Particularly, pressing delete/backspace will wipe out the entire input, making it impossible to make any type of correction, while unexpectedly trashing the user's current selection, forcing them to reselect a date from the beginning.

Another specific case where keyboard interaction is broken is selecting the current value and pressing a number. You can reproduce this directly in https://primereact.org/calendar by:

  1. Selecting a date through the UI.
  2. Selecting all the text in the input box with the mouse.
  3. Entering "2000" with the keyboard.
  4. Realizing you have just typed "000" (the "2" was ignored).

There are likely other cases...

In my opinion, the calendar is not usable as it is. In fact, we are currently deciding against it until these problems are solved, in favor of a plain input box, because we already foresee user complaints from putting it in place.

@inad9300 inad9300 added Status: Discussion Issue or pull request needs to be discussed by Core Team Type: New Feature Issue contains a new feature or new component request labels Mar 6, 2023
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 6, 2023
@userkks
Copy link
Contributor

userkks commented May 19, 2023

Should I work on it, are you guys planning to implement this feature ? @melloware

@melloware
Copy link
Member

you can give it a shot @userkks if you want! PR's are always welcome!

@melloware melloware removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 19, 2023
@userkks
Copy link
Contributor

userkks commented May 19, 2023

Ok, @melloware, you can assign it me then.

userkks added a commit to userkks/primereact that referenced this issue May 22, 2023
userkks added a commit to userkks/primereact that referenced this issue May 25, 2023
userkks added a commit to userkks/primereact that referenced this issue May 31, 2023
userkks added a commit to userkks/primereact that referenced this issue Jun 3, 2023
userkks added a commit to userkks/primereact that referenced this issue Jun 11, 2023
userkks added a commit to userkks/primereact that referenced this issue Jun 19, 2023
userkks added a commit to userkks/primereact that referenced this issue Jun 25, 2023
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Type: New Feature Issue contains a new feature or new component request labels Aug 7, 2023
@inad9300
Copy link
Contributor Author

How's this going? Is @userkks proposal going to make it? Similar to time zone support, I see this as a fundamental feature of date pickers, as their point is to facilitate inputting dates, so the moment they get in the way of that, there is no point in using them.

@melloware melloware added Component: Accessibility Issue or pull request is related to WCAG or ARIA and removed Type: Bug Issue contains a defect related to a specific component. Status: Discussion Issue or pull request needs to be discussed by Core Team labels Feb 24, 2024
@melloware melloware added this to the 10.8.1 milestone Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA
Projects
None yet
3 participants