Responsive - tab view should scroll instead of wrap #6632
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobSiegle
changed the title
|
I was also thinking about trying to PR #1701, but let me know if I shouldn't I see it was mile stoned at one point. |
|
We have plans to implement this differently such as displaying buttons like in PrimeFaces version; https://www.primefaces.org/showcase/ui/panel/tabView.xhtml So in small screens, buttons get displayed to make the headers scrollable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
###Defect Fixes
Fixes #5550.
I did have to change the CSS theme files hopefully it will be clear what changes you need to carry over to your SASS file.
Note: For the close button I added an important tag for the margin - "margin: 0 0 0 0.5em !important;". The margin CSS file for this is overridden by the theme but it might make more sense to just remove the theme style and let it exist in the component CSS. I figured I would let you guys decide.
I tested IE, FF, Edge, Chrome for all 4 tabs orientations.
The CSS is setup so that in left and right mode the tabs can also scroll. To make this work an additional prop would need to be set to define the max height for the tabs wrapper. I did not implement that extra param I wasn't sure if it was needed or not because the tabs still look fine they just get long on the page.