Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: useStyle when id undefined #17092

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

luca-peruzzo
Copy link
Contributor

Fixes #17091

Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Dec 17, 2024 1:42pm

Copy link

vercel bot commented Dec 17, 2024

@luca-peruzzo is attempting to deploy a commit to the primetek Team on Vercel.

A member of the Team first needs to authorize it.

@mertsincan
Copy link
Member

Sorry, but I didn't understand this fix.

document.getElementById(undefined) -> output: null 

So, jumps to the next check

@mertsincan mertsincan merged commit c80a024 into primefaces:master Dec 17, 2024
3 of 4 checks passed
@mertsincan
Copy link
Member

Ahh ok. I checked your attached stackblitz now. Thanks a lot for your contribution!

@luca-peruzzo luca-peruzzo deleted the fix/id-undefined branch December 17, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useStyle: matching document.getElementById(id) when id is undefined could break css injection
2 participants