Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (#17088): typo in input number component content child incrementbuttonicon #17036

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

mariovyord
Copy link
Contributor

@mariovyord mariovyord commented Dec 12, 2024

The naming of the "incrementbuttonicon" content child has a typo:

Currently: "icrementbuttonicon"
Correct: "incrementbuttonicon"

edit: resolved conflicts with master

Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2024 8:47am
primeng-v17 ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2024 8:47am

Copy link

vercel bot commented Dec 12, 2024

@mario-yordanov-vitech is attempting to deploy a commit to the primetek Team on Vercel.

A member of the Team first needs to authorize it.

@mariovyord mariovyord force-pushed the fix-naming-in-input-number branch 2 times, most recently from 7a71d61 to 9f4e6db Compare December 13, 2024 08:44
@mariovyord mariovyord force-pushed the fix-naming-in-input-number branch from 9f4e6db to e34420c Compare December 13, 2024 08:46
@mertsincan mertsincan added the Resolution: Needs Issue An issue needs to be created for the pull request label Dec 16, 2024
@mertsincan
Copy link
Member

Thanks a lot for your contribution! Could you please create an issue for this?

@mertsincan mertsincan added this to the 18.0.1 milestone Dec 16, 2024
@mariovyord mariovyord changed the title fix: typo in input number component content child incrementbuttonicon fix (#17088): typo in input number component content child incrementbuttonicon Dec 17, 2024
@mariovyord
Copy link
Contributor Author

Thanks a lot for your contribution! Could you please create an issue for this?

Of course! Here is the issue #17088

@mertsincan mertsincan removed this from the 18.0.1 milestone Dec 17, 2024
@mertsincan mertsincan removed the Resolution: Needs Issue An issue needs to be created for the pull request label Dec 17, 2024
@mertsincan mertsincan merged commit 7cb6104 into primefaces:master Dec 17, 2024
1 of 2 checks passed
@mertsincan
Copy link
Member

Thanks a lot for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

p-input-number: typo in input number component content child incrementbuttonicon
2 participants