Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#16957 Fix: Dynamic style updates not applied in p-avatar component #16957 #16978

Merged
merged 8 commits into from
Dec 9, 2024

Conversation

joaanyk
Copy link
Contributor

@joaanyk joaanyk commented Dec 7, 2024

Fixes #16957
This PR fixes the issue where dynamic style updates (e.g., background color and text color) are not applied to the p-avatar component.

Fix

  • Added ngOnChanges lifecycle method to detect changes in the style input.
  • Updated template to use a reactive currentStyle property.

Copy link

vercel bot commented Dec 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
primeng-v18 ❌ Failed (Inspect) Dec 7, 2024 5:01pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Dec 7, 2024 5:01pm

Copy link

vercel bot commented Dec 7, 2024

@mateuszstudentzero is attempting to deploy a commit to the primetek Team on Vercel.

A member of the Team first needs to authorize it.

@vercel vercel bot temporarily deployed to Preview – primeng-v18 December 7, 2024 16:25 Inactive
@joaanyk joaanyk changed the title #16957 Fix: Dynamic style updates not applied in p-avatar component #16957 Fix: Dynamic style updates not applied in p-avatar component #16957 Dec 7, 2024
@vercel vercel bot temporarily deployed to Preview – primeng-v18 December 7, 2024 17:01 Inactive
@mertsincan mertsincan merged commit 9df2f0b into primefaces:master Dec 9, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component: Avatar
3 participants