-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calendar - add option to change step size in yearpicker #15419
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Could you please confirm how this appears on mobile and tablet screens? I'm concerned that the default step size might cause some parts to be cut off. |
} | ||
|
||
incrementDecade() { | ||
this.currentYear = this.currentYear + 10; | ||
incrementYearpickerstep() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here, incrementYearPickerStep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed it to "incrementYearPickerStep". ("decrement-" and "stepYearpicker" analoge)
I am not sure about the wording. Maybe "incrementYearPicker" (without "-step") would be better? Or maybe "incrementYearPickerRange" or "incrementYearPickerValues"?
sorry for forcepushing. I squashed some commits, that would add clutter individually. Also I forgot to setup name/mail for git on this machine, and I didn't want "Your Name " and "Your Mail" to pollute the history. |
Hi, Could you please create an issue and link the PR with the issue? |
I completely missed the "open a blank issue" button, sorry. I now made the issue, as requested: #15634 |
Hi, Thanks for the effort and support, merging the PR and making it 10 as default value. |
Fixes #15634
Hi,
This is my first time contribution. I am not sure about the standard operating procedure. If I made a mistake, please point me in the right direction.
As suggested by the contribution-guidelines, I opened a discussion: https://github.com/orgs/primefaces/discussions/1780
After reading the text in the PR-template (see below), I am no longer certain such a discussion is necessary, since this is a small scale feature.
I think this qualifies as "Smaller scaled feature implementations".
Here is what this PR does:
It changes the default step-size for the year picker from 10 to 20 [1]. And it adds a input-parameter to change the stepsize [2]
In the discussion I explain, why I think this feature is usefull. (But I guess it would be ok to let the discussion-page die, and instead move discussions here)
[1]:
[2]: