Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#10093 #10103

Closed
wants to merge 2 commits into from
Closed

#10093 #10103

wants to merge 2 commits into from

Conversation

leifjones
Copy link

Intended as a starting point towards addressing #10093

This should probably involve additional test cases to verify that it was done correctly.

Also, it is not ideal that this involves duplication of code. Perhaps a static helper class could house the function that has been duplicated instead.

@yigitfindikli
Copy link
Contributor

Hi @mrsegen,

Already fixed. Thanks for your effort.

Best Regards.

@leifjones leifjones deleted the 10093 branch April 12, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants