Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add [readonly] attribute to p-inputNumber #9827

Closed
ThorstenKunz opened this issue Jan 26, 2021 · 0 comments · Fixed by #10386
Closed

Add [readonly] attribute to p-inputNumber #9827

ThorstenKunz opened this issue Jan 26, 2021 · 0 comments · Fixed by #10386
Assignees
@mertsincan
Labels
Type: New Feature Issue contains a new feature or new component request
Milestone
12.1.1

Comments

@ThorstenKunz
Copy link

I'm submitting a ... (check one with "x")

[ ] bug report => Search github for a similar issue or PR before submitting
[X] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

It would be great if there was a simple [readonly] attribute added to the p-inputNumber component like it is present already on lots of other input style components.

Thanks
@yigitfindikli yigitfindikli added the Type: New Feature Issue contains a new feature or new component request label Feb 12, 2021
LeGorge added a commit to LeGorge/primeng that referenced this issue Jul 2, 2021
@LeGorge
Adds readonly attribute to p-inputNumber
5907600 
 - Defaults to false
 - Does not display buttons when readonly is set
 - Updates the showcase documentation
 - Adds tests for p-inputNumber default displayability as done in other inputs
 - Adds tests for readonly rules
 - closes primefaces#9827
@LeGorge LeGorge mentioned this issue Jul 2, 2021
Merged
mertsincan added a commit that referenced this issue Sep 6, 2021
@mertsincan
Fixed #9827 - Add [readonly] attribute to p-inputNumber
66f0896 
Adds readonly attribute to p-inputNumber
@mertsincan mertsincan added this to the 12.1.1 milestone Sep 6, 2021
@mertsincan mertsincan self-assigned this Sep 6, 2021
mertsincan added a commit that referenced this issue Sep 6, 2021
@mertsincan
Refactor #9827
19d9775
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mertsincan mertsincan

Labels
Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Milestone
12.1.1
Development

Successfully merging a pull request may close this issue.

Adds readonly attribute to p-inputNumber LeGorge/primeng
3 participants
@mertsincan @yigitfindikli @ThorstenKunz