Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: aria-sort not updated when sorting multiple columns #17090

Closed
ben-lewis-wtw opened this issue Dec 17, 2024 · 0 comments
Closed

Table: aria-sort not updated when sorting multiple columns #17090

ben-lewis-wtw opened this issue Dec 17, 2024 · 0 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@ben-lewis-wtw
Copy link

Describe the bug

Appears to be a regression of #11051.

When sorting a column on a p-table with sortMode="multiple", the aria-sort attribute of the table column header is stuck as ascending, and does not update to descending.

This can be observed on the PrimeNG showcase (https://primeng.org/table#multiple-columns-sort) and on the linked stackblitz reproduction.

Environment

Angular 18, PrimeNG 18, Chrome

Reproducer

https://stackblitz.com/edit/github-gdsf7p9w?file=src%2Fapp%2Fapp.component.html

Angular version

18.0.1

PrimeNG version

^18.0.0-rc.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.20.3

Browser(s)

Chrome 131.0.6778.140

Steps to reproduce the behavior

  1. On a p-table with sortMode="multiple", click a column header to enable sorting on that column.
  2. Open devtools and inspect the <th> element of the sorted column.
  3. Note that aria-sort is ascending.
  4. Click the column header again to change the sort order.
  5. Note that aria-sort is still ascending, when it should now be descending`.

Expected behavior

aria-sort should reflect the correct sort direction of the column.

@ben-lewis-wtw ben-lewis-wtw added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 17, 2024
@mertsincan mertsincan added this to the 18.0.1 milestone Dec 17, 2024
@mertsincan mertsincan self-assigned this Dec 17, 2024
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Dec 17, 2024
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 17, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in PrimeNG Dec 17, 2024
@mertsincan mertsincan added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
Status: Done
Development

No branches or pull requests

2 participants