Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table multi sort aria attributes are not updated #11051

Closed
JulianFarhi opened this issue Jan 11, 2022 · 3 comments
Closed

Table multi sort aria attributes are not updated #11051

JulianFarhi opened this issue Jan 11, 2022 · 3 comments

Comments

@JulianFarhi
Copy link

[X] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Current behavior
When clicking on the table header (multi sort options) that is currently in "ascending" order, the aria-sort value is still "ascending".

Expected behavior
The value of the aria-sort must change to "descending"

Minimal reproduction of the problem with instructions
It can be reproduced directly on the demo (v12.2.4):
https://www.primefaces.org/primeng/showcase/#/table/sort

@yigitfindikli
Copy link
Contributor

All accessibility issues will be fixed in 2022 Q1. We're gonna publish accessibility scores as well. Thanks for your report.

@ben-lewis-wtw
Copy link

I am still experiencing this issue on v18, and can also reproduce it on the PrimeNG showcase page with the same steps: https://primeng.org/table#multiple-columns-sort

@mertsincan
Copy link
Member

@ben-lewis-wtw Thanks a lot for your update! Could you please create a new issue for it? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants