p-dialog [focusOnShow]="true" Maximum call stack size exceeded

[kubedan]

Describe the bug

If I set the property [focusOnShow]="true" in the p-dialog component and the body of the dialog and the p-footer of the dialog do not contain a focusable element, it results in a "Maximum call stack size exceeded" error.

<p-dialog
  [visible]="true"  
  [focusOnShow]="true">
  Body:  Any focusable element.
  <p-footer>Footer:  Any focusable element.</p-footer>
</p-dialog>

The problem is here
(https://github.com/primefaces/primeng/blob/e804cd63eeadcb6cede73aab108fdd167dc28d5f/src/app/components/dialog/dialog.ts#L601C5-L619C1) where this.focus(this.footerViewChild.nativeElement); is called infinitely.

Environment

Doesnt matter

Reproducer

https://github-seqmj3.stackblitz.io/

Angular version

17.3.11

PrimeNG version

17.18.3

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

v18.20.3

Browser(s)

No response

Steps to reproduce the behavior

1. Go to https://github-seqmj3.stackblitz.io/ or https://stackblitz.com/edit/github-seqmj3
2. See error in console.
   

Expected behavior

The component does not crash even if it does not have a focusable

Proposed Fix

--- a/src/app/components/dialog/dialog.ts	
+++ b/src/app/components/dialog/dialog.ts	
@@ -611,7 +611,7 @@
             this.zone.runOutsideAngular(() => {
                 setTimeout(() => focusableElement.focus(), 5);
             });
-        } else if (this.footerViewChild) {
+        } else if (this.footerViewChild && focusParentElement !== this.footerViewChild.nativeElement) {
             // If the content section is empty try to focus on footer
             this.focus(this.footerViewChild.nativeElement);
         }