Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog: Focus to input element set before transition ends #15749

Closed
KevinHetzelGFL opened this issue May 30, 2024 · 0 comments · Fixed by #15992 · 4 remaining pull requests
Closed

Dialog: Focus to input element set before transition ends #15749

KevinHetzelGFL opened this issue May 30, 2024 · 0 comments · Fixed by #15992 · 4 remaining pull requests
Assignees
@mehmetcetin01140
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.18.4

Comments

@KevinHetzelGFL
Copy link

KevinHetzelGFL commented May 30, 2024 •
edited
Loading

Describe the bug

with focusOnShow=true, the element is focues before the transition of the dialog is complete. A calendar inside the dialog is opened on the wrong position and outside of the display. You can fix it with transitionOptions="",
image

Environment

Windows 11,
VS Code
node v18
npm 10.5.0

Reproducer

https://stackblitz.com/edit/am62x2-n2bhjj?file=src%2Fapp%2Fdialog-basic-demo.html

Angular version

17.3.8

PrimeNG version

17.17.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.13.0

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@KevinHetzelGFL KevinHetzelGFL added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 30, 2024
@mehmetcetin01140 mehmetcetin01140 added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jul 10, 2024
@mehmetcetin01140 mehmetcetin01140 self-assigned this Jul 10, 2024
@mehmetcetin01140 mehmetcetin01140 added this to the 17.18.4 milestone Jul 10, 2024
@mehmetcetin01140 mehmetcetin01140 mentioned this issue Jul 10, 2024
Merged
cetincakiroglu added a commit that referenced this issue Jul 11, 2024
@cetincakiroglu
Merge pull request #15992 from primefaces/issue-15749
866c5a8 
Fixed #15749 - Dialog: Focus to input element set before transition ends
@Rodolphe33 Rodolphe33 mentioned this issue Aug 2, 2024
Open
@Rodolphe33 Rodolphe33 mentioned this issue Aug 9, 2024
Open
@lakshamanr lakshamanr mentioned this issue Aug 9, 2024
Closed
This was referenced Aug 16, 2024
Open
Open
This was referenced Aug 30, 2024
Open
Open
mehmetcetin01140 added a commit that referenced this issue Nov 15, 2024
@mehmetcetin01140
Fixed #15749 | Dialog: Focus to input element set before transition ends
5397623
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mehmetcetin01140 mehmetcetin01140

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.18.4
2 participants
@KevinHetzelGFL @mehmetcetin01140