Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Angular 18 #15661

Closed
swami-sanapathi opened this issue May 23, 2024 · 10 comments · Fixed by #15747 · 4 remaining pull requests
Closed

Support for Angular 18 #15661

swami-sanapathi opened this issue May 23, 2024 · 10 comments · Fixed by #15747 · 4 remaining pull requests
Assignees
Labels
Type: New Feature Issue contains a new feature or new component request
Milestone

Comments

@swami-sanapathi
Copy link
Contributor

Describe the bug

Angular 18 has been released, please consider adding support for it.

Environment

all envs

Reproducer

No response

Angular version

18.0.0

PrimeNG version

17.17.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

0.0.0

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

@swami-sanapathi swami-sanapathi added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 23, 2024
@Tenmak
Copy link

Tenmak commented May 23, 2024

They have an on-going branch for Angular v18, so they just need some time to spend on migrating.

https://github.com/primefaces/primeng/tree/v18

@NateRadebaugh
Copy link

@mehmetcetin01140 it looks like you've been contributing to that v18 branch -- is angular 18 support something planned in the near future? I understand there's additional features/updates that may be part of that branch, but I'm wondering if there's anything the community can do to help you all get the initial ng18 support released in the meantime?

cc @cetincakiroglu @cagataycivici

@MAN-Sendance
Copy link

Angular v18 support would be great. I hope it does not take too long until we get it. :)

@cetincakiroglu
Copy link
Contributor

Hi all,

We are currently working on PrimeNG 18. This update will bring significant changes not only in terms of Angular 18 support but also in theming. Our current theming application progresses through scss files, and updating theming is only possible to a limited extent with primeng-sass-theme or ng-deep. With PrimeNG 18, we will change this situation and introduce the new theming with a more modern approach. All theming elements will now be customizable with browser variables, eliminating the need for the primeng-sass-theme library. We have already tested this with primevue v4, which you can review at v4.primevue.org. In addition to theming, we are also making improvements to some components. This update will not happen quickly like past major updates because completely changing theming from scratch and creating a custom build mechanism are significant tasks and will take a certain amount of time, but we plan not to prolong this time too much, with a maximum estimate of 1 month.

@NateRadebaugh @Tenmak @swami-sanapathi @vincent

@cetincakiroglu cetincakiroglu added Type: New Feature Issue contains a new feature or new component request and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels May 28, 2024
@cetincakiroglu cetincakiroglu added this to the 18.0.0-rc.1 milestone May 28, 2024
@cetincakiroglu cetincakiroglu self-assigned this May 28, 2024
@NateRadebaugh
Copy link

@cetincakiroglu thank you I understand and appreciate the larger scope of the Angular 18 release.

What I am wondering is whether it would be possible to more quickly have a release that purely updates the dependency versions so unblock consumers of the application to fully and safely update to angular 18 without dependency mismatch errors. And then have a subsequent primeng 18.x release that would include the more thorough theming revamp.

I'm not sure how semantic versioning would support that, as it would depend on whether the theming refactor would be considered breaking change, or backwards compatible with existing CSS.

@MAN-Sendance
Copy link

@NateRadebaugh that's exactly what I thought too when I read @cetincakiroglu's comment.

@cetincakiroglu
Copy link
Contributor

Hi @NateRadebaugh @MAN-Sendance

We've tested the PrimeNG v17 with Angular 18 and found that we don't need to wait for PrimeNG 18 for Angular 18 support. We're planning to release v17.18.0 this week with peer dependency fixes. This will allow users to use PrimeNG 17 with both Angular 17 and 18. Other breaking changes and theming updates will be introduced in PrimeNG 18.

@cetincakiroglu cetincakiroglu modified the milestones: 18.0.0-rc.1, 17.17.1 May 29, 2024
@MAN-Sendance
Copy link

MAN-Sendance commented May 30, 2024

We've tested the PrimeNG v17 with Angular 18 and found that we don't need to wait for PrimeNG 18 for Angular 18 support. We're planning to release v17.18.0 this week with peer dependency fixes. This will allow users to use PrimeNG 17 with both Angular 17 and 18. Other breaking changes and theming updates will be introduced in PrimeNG 18.

Wow, thanks a million! @cetincakiroglu

@swami-sanapathi
Copy link
Contributor Author

Thanks @cetincakiroglu ❤️

@swami-sanapathi
Copy link
Contributor Author

ES Lint support for v18 was released a few hours ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment