Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: Button: Opacity is applied twice on disabled state --> wrong opacity #15651

Closed
demike opened this issue May 22, 2024 · 0 comments · Fixed by #15822 · 4 remaining pull requests
Closed

Component: Button: Opacity is applied twice on disabled state --> wrong opacity #15651

demike opened this issue May 22, 2024 · 0 comments · Fixed by #15822 · 4 remaining pull requests
Assignees
Labels
LTS-FIXED-15.4.21 LTS-FIXED-16.9.11 LTS-PORTABLE Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@demike
Copy link

demike commented May 22, 2024

Describe the bug

disabled button gets power of 2 opacity.
This is because of the change 919f892

Now the class p-disabled is applied to the host element and the button element inside

i.e.: if we wanted to achieve an opacity of 0.3 the result would be 0.3*0.3 = 0.09
This makes working with figma values super annoying

Hint:
removing the p-disabled on the button does not fix the problem, as
the css looks like

.p-disabled, .p-component:disabled {
    opacity: 0.6;
}

and the button also has the p-componet:disable on it

p-disabled should be removed from p-button and just the pointer-events: none should be applied to there

Environment

Windows

Reproducer

No response

Angular version

17.2.0

PrimeNG version

17.17.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.20.2

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

opacity should only be applied once!

@demike demike added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 22, 2024
@demike demike changed the title Component: Button Component: Button: Opacity is applied twice on disabled state --> wrong opacity May 22, 2024
@mehmetcetin01140 mehmetcetin01140 self-assigned this Jun 11, 2024
@mehmetcetin01140 mehmetcetin01140 added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jun 11, 2024
@mehmetcetin01140 mehmetcetin01140 added this to the 17.18.1 milestone Jun 11, 2024
cetincakiroglu added a commit that referenced this issue Jun 13, 2024
Fixed #15651 - Button |  Opacity is applied twice on disabled state -…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment