Button | Remove wrapper span elements from icon templates

[cetincakiroglu]

Span elements wrapping around the icon templates may cause styling issues in other icon libraries. To prevent any additional styles coming from the PrimeNG, we'll remove wrapper span elements to allow users to customize their choice of icon. Additionally, a new class template parameter will be provided.

Example:

            <p-button label="Test Material Symbol icon">
                <ng-template pTemplate="icon" let-class="class">
                    <span class="material-symbols-outlined" [ngClass]="class">info</span>
                </ng-template>
            </p-button>

[rokamon1997]

Is it possible this broke the "pi-spin" icon functionality? With version 17.17.0 simple button with pi-spin class doesn't seem to work anymore.

This does not work.
<p-button icon="pi pi-spinner pi-spin"></p-button>

Temporary fix for me is to use classic button with pButton directive instead.

[rokamon1997]

Neither does this work if I try to use the loading properties. The spinner icon and spinning works but when loading stops it doesn't show the correct icon.

<p-button icon="pi pi-step-forward" loadingIcon="pi pi-spinner" [loading]="loading()"></p-button>