Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog: Material Design close button regression #14916

Closed
PeterHewat opened this issue Mar 1, 2024 · 3 comments · Fixed by #16117 · 4 remaining pull requests
Closed

Dialog: Material Design close button regression #14916

PeterHewat opened this issue Mar 1, 2024 · 3 comments · Fixed by #16117 · 4 remaining pull requests
Assignees
@mehmetcetin01140
Labels
PRO Support Issue was reported by PRO User Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.18.7

Comments

@PeterHewat
Copy link

Describe the bug

With the Material Design theme, the dialogue close button is oval-shaped (visible on hover). It used to be round. This is due to the addition of .p-button that wasn't there before. This .p-button class has the property min-width: 4rem;
This issue might be present in other buttons that should be round so please check them all.

Environment

All

Reproducer

No response

Angular version

17.*

PrimeNG version

17.9.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

All

Browser(s)

All

Steps to reproduce the behavior

Go to documentation https://primeng.org/dialog
Select theme Material Design
Hover over close button

Expected behavior

The button should be round but it is oval in shape.
@PeterHewat PeterHewat added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 1, 2024
@PeterHewat
Copy link
Author

PrimeNG-materialdesign-close-dialog-button-regression

@mehmetcetin01140 mehmetcetin01140 added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Mar 4, 2024
@PeterHewat
Copy link
Author

This issue is still present in PrimeNG 17.12.0

tiagohm added a commit to tiagohm/nebulosa that referenced this issue Apr 14, 2024
@tiagohm
[desktop]: Fix dialog close button oval-shaped
3f33f1f 
primefaces/primeng#14916
@PeterHewat
Copy link
Author

This issue is still present in PrimeNG 17.18.6

@mehmetcetin01140 mehmetcetin01140 added this to the 17.18.7 milestone Jul 29, 2024
@mehmetcetin01140 mehmetcetin01140 added the PRO Support Issue was reported by PRO User label Jul 29, 2024
@mehmetcetin01140 mehmetcetin01140 self-assigned this Jul 29, 2024
mehmetcetin01140 added a commit that referenced this issue Jul 29, 2024
@mehmetcetin01140
Fixed #14916 - Dialog | Material Design close button regression
2b528d6
@mehmetcetin01140 mehmetcetin01140 mentioned this issue Jul 29, 2024
Merged
cetincakiroglu added a commit that referenced this issue Aug 1, 2024
@cetincakiroglu
Merge pull request #16117 from primefaces/issue-14916
e7d9e1c 
Fixed #14916 - Dialog | Material Design close button regression
@Rodolphe33 Rodolphe33 mentioned this issue Aug 23, 2024
Open
This was referenced Aug 30, 2024
Open
Open
This was referenced Sep 8, 2024
Open
Open
@Rodolphe33 Rodolphe33 mentioned this issue Sep 20, 2024
Open
@Rodolphe33 Rodolphe33 mentioned this issue Oct 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mehmetcetin01140 mehmetcetin01140

Labels
PRO Support Issue was reported by PRO User Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.18.7
2 participants
@PeterHewat @mehmetcetin01140