Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button: loading style issue when already has an icon #13148

Closed
itismohammadreza opened this issue Jun 6, 2023 · 2 comments · Fixed by #13173
Closed

Button: loading style issue when already has an icon #13148

itismohammadreza opened this issue Jun 6, 2023 · 2 comments · Fixed by #13173
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
16.0.1

Comments

@itismohammadreza
Copy link
Contributor

Describe the bug

The loading icon has no margin from label, if already there is an icon.

Environment

windows

Reproducer

https://stackblitz.com/edit/r6awcv?file=package.json,src%2Fapp%2Fdemo%2Fbutton-loading-demo.html

Angular version

16.0.1

PrimeNG version

16.0.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.16.0

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@itismohammadreza itismohammadreza added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jun 6, 2023
@Estrolldomezx
Copy link

Estrolldomezx commented Jun 6, 2023 •
edited
Loading

<button pButton pRipple class="ml-2" label="Submit" type="button" icon="pi pi-home" [loading]="loading" (click)="load()"></button>

@itismohammadreza
Copy link
Contributor Author

@Estrolldomezx Thanks,
Suppose I'm not using the bootstrap. although you add margin to button own. but the loading icon needs margin.

volvachev added a commit to volvachev/primeng that referenced this issue Jun 12, 2023
@volvachev
fix(primeng/p-button): spinner style not working propely
a483588 
Fixes primefaces#13148.
@volvachev volvachev mentioned this issue Jun 12, 2023
Merged
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jun 16, 2023
@cetincakiroglu cetincakiroglu added this to the 16.0.1 milestone Jun 16, 2023
@gerjon-eatch gerjon-eatch mentioned this issue Aug 8, 2023
Closed
steve3d pushed a commit to steve3d/primeng that referenced this issue Aug 28, 2023
@volvachev @steve3d
fix(primeng/p-button): spinner style not working propely
e421722 
Fixes primefaces#13148.
mertsincan pushed a commit that referenced this issue Aug 29, 2023
@steve3d @volvachev
@cetincakiroglu @gucal @barais
feat: Add custom style class to p-table p-dataview p-treeview (#13205)
6069219 
* feat: Add custom style class to p-table/p-dataview/p-treeview

* fix(primeng/p-button): spinner style not working propely

Fixes #13148.

* Fixed #13183 - Make TreeNode generic

* Fix: Icon list visibility

* fix(primeng/p-menu): render html via `DomSanitizer`

Fixes #13128.

* fix(primeng/p-button): not working `loadingIcon` property, update loadingdoc example

Fixes #13098.

* fix: update angular version restriction

* fix(primeng/p-confirmDialog): not updated style in runtime

Fixes #13155.

* Fix #13129 - FileUpload | File limit does not fire error

* Fix #13201 - OverlayPanel: Incorrect position when inside of dialog in 16.0.0 (did not happen in rc2)

* Fix - Surface color list

* fix #13124

---------

Co-authored-by: Egor Volvachev <[email protected]>
Co-authored-by: Çetin <[email protected]>
Co-authored-by: gucal <[email protected]>
Co-authored-by: Olivier Barais <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
16.0.1
Development

Successfully merging a pull request may close this issue.

fix(primeng/p-button): spinner style not working propely volvachev/primeng
3 participants
@itismohammadreza @Estrolldomezx @cetincakiroglu