Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListBox: Incorrect value for "aria-multiselectable" attribute ( WCAG: 4.1.2 violation) #11743

Closed
lcameron-vs opened this issue Jul 26, 2022 · 1 comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@lcameron-vs
Copy link
Contributor

Describe the bug

Template for Listbox in src/app/components/listbox/listbox.ts incorrectly assigns the aria-multiselectable attribute a value of the string "multiple". This results in an invalid value for the attribute; should only be true | false.

ListBox has a boolean input multiple, so this binding should change:

-            <ul class="p-listbox-list" role="listbox" aria-multiselectable="multiple">
+            <ul class="p-listbox-list" role="listbox" [attr.aria-multiselectable]="multiple">

Environment

N/A

Reproducer

No response

Angular version

N/A

PrimeNG version

14.0.0

Build / Runtime

Angular CLI App

Language

ALL

Node version (for AoT issues node --version)

N/A

Browser(s)

No response

Steps to reproduce the behavior

  1. Go to http://primefaces.org/primeng/listbox
  2. Right-click and inspect HTML for any listbox
  3. Inspect aria-multiselectable value for ul.p-listbox-list

Actual result:
<ul class="p-listbox-list" role="listbox" aria-multiselectable="multiple">

Expected behavior

Expected result(s):
<ul class="p-listbox-list" role="listbox" aria-multiselectable="true | false">

@lcameron-vs lcameron-vs added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Jul 26, 2022
@cetincakiroglu
Copy link
Contributor

Hi,

Accessibility is a major concern of the Prime UI libraries and PrimeNG is no exception. PrimeTek teams have initiated a significant process to review and enhance the accessibility features of the components. This guide documents the foundation of the general guidelines that PrimeNG will follow and each component documentation will have a separate Accessibility section that states the keyboard support, screen reader compatibility, the implementation details along with tips to achieve WCAG compliancy. This work has been initiated in Q2 2022 and planned to be completed by early Q3. PrimeNG will be the reference implementation which then will be ported to PrimeFaces, PrimeNG and PrimeVue.

@cetincakiroglu cetincakiroglu added Component: Accessibility Issue or pull request is related to WCAG or ARIA and removed Type: Bug Issue contains a bug related to a specific component. Something about the component is not working labels Aug 8, 2022
@cetincakiroglu cetincakiroglu added this to the 14.0.3 milestone Sep 9, 2022
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Component: Accessibility Issue or pull request is related to WCAG or ARIA labels Sep 9, 2022
cetincakiroglu added a commit that referenced this issue Sep 9, 2022
Listbox: Fixed aria-multiselectable attribute binding. Fixes #11743
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants