Fixed #11384 - onChange event triggered for selectButton even when no…

… change occurs
primefaces · Apr 4, 2022 · 5b0deb7 · 5b0deb7
1 parent 1989abf
commit 5b0deb7
Showing 1 changed file with 18 additions and 7 deletions.
diff --git a/src/app/components/selectbutton/selectbutton.ts b/src/app/components/selectbutton/selectbutton.ts
@@ -116,9 +116,26 @@ export class SelectButton implements ControlValueAccessor {
                 this.removeOption(option);
             else
                 this.value = [...(this.value||[]), this.getOptionValue(option)];
+
+            this.onModelChange(this.value);
+
+            this.onChange.emit({
+                originalEvent: event,
+                value: this.value
+            });
         }
         else {
-            this.value = this.getOptionValue(option);
+            let value = this.getOptionValue(option);
+
+            if (this.value !== value) {
+                this.value = this.getOptionValue(option);
+                this.onModelChange(this.value);
+
+                this.onChange.emit({
+                    originalEvent: event,
+                    value: this.value
+                });
+            }
         }
 
         this.onOptionClick.emit({
@@ -127,12 +144,6 @@ export class SelectButton implements ControlValueAccessor {
             index: index
         });
 
-        this.onModelChange(this.value);
-
-        this.onChange.emit({
-            originalEvent: event,
-            value: this.value
-        });
     }
 
     onBlur() {