Merge pull request #15838 from primefaces/issue-15837

Fixed #15837 - Accessibility: Buttons within an accordion header temp…
primefaces · Jun 13, 2024 · 52e3607 · 52e3607
2 parents e5f593e + 183321e
commit 52e3607
Showing 1 changed file with 5 additions and 10 deletions.
diff --git a/src/app/components/accordion/accordion.ts b/src/app/components/accordion/accordion.ts
@@ -230,11 +230,7 @@ export class AccordionTab implements AfterContentInit, OnDestroy {
 
     accordion: Accordion;
 
-    constructor(
-        @Inject(forwardRef(() => Accordion)) accordion: Accordion,
-        public el: ElementRef,
-        public changeDetector: ChangeDetectorRef
-    ) {
+    constructor(@Inject(forwardRef(() => Accordion)) accordion: Accordion, public el: ElementRef, public changeDetector: ChangeDetectorRef) {
         this.accordion = accordion as Accordion;
         this.id = UniqueComponentId();
     }
@@ -262,7 +258,9 @@ export class AccordionTab implements AfterContentInit, OnDestroy {
     }
 
     toggle(event?: MouseEvent | KeyboardEvent) {
-        if (this.disabled) {
+        const target = event.target as HTMLElement;
+
+        if (this.disabled || !(target.tagName.toLowerCase() === 'a' && target.classList.contains('p-accordion-header-link'))) {
             return false;
         }
 
@@ -441,10 +439,7 @@ export class Accordion implements BlockableUI, AfterContentInit, OnDestroy {
 
     public tabs: AccordionTab[] = [];
 
-    constructor(
-        public el: ElementRef,
-        public changeDetector: ChangeDetectorRef
-    ) {}
+    constructor(public el: ElementRef, public changeDetector: ChangeDetectorRef) {}
 
     @HostListener('keydown', ['$event'])
     onKeydown(event) {