Skip to content

Commit

Permalink
Merge pull request #15872 from primefaces/issue-15851
Browse files Browse the repository at this point in the history
Fixed #15851 - Component: Accordion
  • Loading branch information
cetincakiroglu authored Jun 27, 2024
2 parents 785ec5a + ecea54b commit 2901f73
Showing 1 changed file with 4 additions and 11 deletions.
15 changes: 4 additions & 11 deletions src/app/components/accordion/accordion.ts
Original file line number Diff line number Diff line change
Expand Up @@ -230,11 +230,7 @@ export class AccordionTab implements AfterContentInit, OnDestroy {

accordion: Accordion;

constructor(
@Inject(forwardRef(() => Accordion)) accordion: Accordion,
public el: ElementRef,
public changeDetector: ChangeDetectorRef
) {
constructor(@Inject(forwardRef(() => Accordion)) accordion: Accordion, public el: ElementRef, public changeDetector: ChangeDetectorRef) {
this.accordion = accordion as Accordion;
this.id = UniqueComponentId();
}
Expand Down Expand Up @@ -262,9 +258,8 @@ export class AccordionTab implements AfterContentInit, OnDestroy {
}

toggle(event?: MouseEvent | KeyboardEvent) {
const target = event.target as HTMLElement;

if (this.disabled || !(target.tagName.toLowerCase() === 'a' && target.classList.contains('p-accordion-header-link'))) {
if (this.disabled) {
return false;
}

Expand Down Expand Up @@ -443,10 +438,7 @@ export class Accordion implements BlockableUI, AfterContentInit, OnDestroy {

public tabs: AccordionTab[] = [];

constructor(
public el: ElementRef,
public changeDetector: ChangeDetectorRef
) {}
constructor(public el: ElementRef, public changeDetector: ChangeDetectorRef) {}

@HostListener('keydown', ['$event'])
onKeydown(event) {
Expand Down Expand Up @@ -646,3 +638,4 @@ export class Accordion implements BlockableUI, AfterContentInit, OnDestroy {
declarations: [Accordion, AccordionTab]
})
export class AccordionModule {}

0 comments on commit 2901f73

Please sign in to comment.