Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing padding-top-bottom inside .p-field.p-grid #29

Closed
ProfEibe opened this issue Aug 6, 2020 · 1 comment
Closed

Missing padding-top-bottom inside .p-field.p-grid #29

ProfEibe opened this issue Aug 6, 2020 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@ProfEibe
Copy link
Contributor

ProfEibe commented Aug 6, 2020

There is an inconsistency in the formLayout.scss

Most columnsizes get padding-top and -bottom 0 when used inside .p-field-p-grid. But size 1, 7 and 9 only inside .formgrid.p-grid. I think there was a change not done on all places.

.p-field.p-grid .p-col-fixed,
.p-formgrid.p-grid .p-col-fixed,
.p-field.p-grid .p-col,
.p-formgrid.p-grid .p-col,
.p-formgroup .p-grid .p-col-1, 
.p-formgrid.p-grid .p-col-1, 
.p-field.p-grid .p-col-2,
.p-formgrid.p-grid .p-col-2, 
.p-field.p-grid .p-col-3, 
.p-formgrid.p-grid .p-col-3, 
.p-field.p-grid .p-col-4, 
.p-formgroup.p-grid .p-col-4, 
.p-field.p-grid .p-col-5, 
.p-formgrid.p-grid .p-col-5, 
.p-field.p-grid .p-col-6, 
.p-formgrid.p-grid .p-col-6,
.p-formgroup .p-grid .p-col-7, 
.p-formgrid.p-grid .p-col-7, 
.p-field.p-grid .p-col-8, 
.p-formgrid.p-grid .p-col-8, 
.p-formgroup .p-grid .p-col-9, 
.p-formgrid.p-grid .p-col-9,
.p-field.p-grid .p-col-10, 
.p-formgrid.p-grid .p-col-10, 
.p-field.p-grid .p-col-11, 
.p-formgroup.p-grid .p-col-11, 
.p-field.p-grid .p-col-12,
.p-formgrid.p-grid .p-col-12 {
    padding-top: 0;
    padding-bottom: 0;
}

If you like I can fix it and send a pullrequest.

@ProfEibe
Copy link
Contributor Author

ProfEibe commented Aug 7, 2020

#30 I´ve done i. Hope its correct.

@cagataycivici cagataycivici self-assigned this Aug 26, 2020
@cagataycivici cagataycivici added the bug Something isn't working label Aug 26, 2020
@cagataycivici cagataycivici added this to the 2.0.0 milestone Aug 26, 2020
cagataycivici added a commit that referenced this issue Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants