Content Type Check + Leaner Simulator JAR #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wied03
force-pushed
the
cors_flexibility
branch
2 times, most recently
from
3bbc943 to
05bc662
Compare
wied03
force-pushed
the
wied03/leaner_simulator_jar
branch
from
85e2a88 to
bd58252
Compare
wied03
force-pushed
the
wied03/leaner_simulator_jar
branch
from
5296e5d to
3fd43f1
Compare
wied03
changed the title
…anyways Pull the nested classes out, such that: 1) We don't have to craft a regex to deal with including RequestResult$TestURIBuilder.class, but still exclude the other tests 2) RequestResult is not so big
|
Over the weekend, it occurred to me I should diff the JARs just to be sure. and I found some issues that I fixed with more regex's. I ran this with a couple cleanspeak apps and it worked fine, I think this path, although it can work OK, it feels brittle. To me the best way to solve it though may not be attainable right now because it ideally would require multi-module building. We'd need these modules:
To me this would be the only "foolproof" way of ensuring that the simulator JAR ends up with all the right classes in it, even if they are refactored/moved around. We could imitate that with Savant by adding more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Published simulator JAR, as is, has all the tests for PMVC itself in it as well, which is not needed on other projects. Alternatively, perhaps better, the simulator source could be moved to a different directory so we are not cherry picking with regexes quite as much but that might require more Savant changes.
JSON assertions do not check the content type. It's unlikely it would be wrong, but this ensures it's checked.