Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax dependency versions for opentelemetry deps #66

Merged
merged 3 commits into from
Sep 5, 2022

Conversation

mosic
Copy link
Contributor

@mosic mosic commented Sep 5, 2022

I ran into this while trying to update opentelemetry_api in this PR: primait/prima_opentelemetry_ex#23

Failed to use "opentelemetry_api" (version 1.1.0) because
  opentelemetry (version 1.1.1) requires ~> 1.1
  opentelemetry_absinthe (version 1.0.0) requires ~> 1.0
  opentelemetry_ecto (version 1.0.0) requires ~> 1.0
  opentelemetry_exporter (version 1.1.1) requires ~> 1.1
  teleplug (version 1.0.0) requires ~> 1.0.0
  mix.lock specifies 1.1.0

I also updated opentelemetry deps and bumped up the version number.

@mosic mosic requested a review from Fs00 September 5, 2022 10:23
Copy link

@Fs00 Fs00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I would just bump the teleplug version to 1.0.1 since we are not adding any new features to the library

@mosic mosic force-pushed the relax-opentelemetry-version branch from 907475d to 262935b Compare September 5, 2022 10:39
@mosic
Copy link
Contributor Author

mosic commented Sep 5, 2022

Fair enough, updated to 1.0.1 👍

@mosic
Copy link
Contributor Author

mosic commented Sep 5, 2022

@Fs00 Can you merge it as well? UK devs don't have the required permissions in this repo.

@cottinisimone cottinisimone merged commit 3245cec into master Sep 5, 2022
@cottinisimone cottinisimone deleted the relax-opentelemetry-version branch September 5, 2022 10:51
@Fs00
Copy link

Fs00 commented Sep 5, 2022

Released version 1.0.1 on hex.pm

@mosic
Copy link
Contributor Author

mosic commented Sep 5, 2022

Thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants