Feat: nickname 생성 구현 #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
닉네임 자동 생성 + update 기능을 구현했습니다. 추가로 memberId 참조를 전부 profileId 참조로 변경했습니다 Related to: prgrms-be-devcourse#10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
닉네임 자동 생성 + update 기능을 구현했습니다. 추가로 memberId 참조를 전부 profileId 참조로 변경했습니다
closed #10
#️⃣연관된 이슈
☑️ PR 유형
📝 작업 내용
Profile 참조를 memberId 가 아닌 profileId 로 변경하였습니다
nickname 을 더이상 member 측에서 참조하지 않습니다! 나중에 member 측 닉네임 관련 기능들을 제거하겠습니다
nickname 은 최초 생성시 default#? 형태로 구현되며, update 를 통해서 변경이 가능합니다. 또한 중복이 불가능 하게 구현했습니다
마지막으로 create 관련 controller, service 를 전부 제거했습니다. profile 은 기본적으로 Member 생성시 자동 생성만이 가능합니다
✅ 피드백 반영사항
💬 리뷰 요구사항