[POM-94] feat: image 관련 mappedSuperclass로 분리, menu 도메인 엔티티 validation 및 전체적 구조 설정 #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juno-junho
requested review from
hyeon-z,
choi5798,
Juhongseok,
beomukim and
ddongpuri
hyeon-z
reviewed
Sep 18, 2023
|
|
||
| private final MenuService menuService; | ||
|
|
||
| @PostMapping({"{storeId}"}) |
There was a problem hiding this comment.
중괄호 잘못 들어갔네요 ㅋㅋ
src/main/java/com/ray/pominowner/menu/controller/MenuController.java
Outdated
Show resolved
Hide resolved
Juhongseok
reviewed
Sep 18, 2023
src/main/java/com/ray/pominowner/global/domain/BaseFileEntity.java
Outdated
Show resolved
Hide resolved
choi5798
approved these changes
Sep 18, 2023
| private String uploadName; | ||
|
|
||
| private String fileName; | ||
|
|
||
| @ManyToOne(fetch = LAZY) | ||
| @JoinColumn(name = "STORE_ID") | ||
| private Store store; | ||
|
|
||
| @Builder | ||
| private StoreImage(String path, String uploadName, String fileName, Store store) { |
There was a problem hiding this comment.
이 private 생성자는 어디에서 호출 되나요?
There was a problem hiding this comment.
호출 안되고 builder로만 사용하려고 막아놓은거에요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 설명