[POM-84] test: 중복된 엔티티 객체 생성 코드 분리 #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juno-junho
approved these changes
Sep 18, 2023
| return new Fee(PGType.TOSS, 10000); | ||
| } | ||
|
|
||
|
|
|
|
||
| // then | ||
| assertThat(sales).isNotNull(); | ||
| assertThat(sales()).isNotNull(); |
There was a problem hiding this comment.
예외를 던지지 않는다는 메서드로 변경하는게 어떨까요? 생성 자체가 되면 안되는거 아닌가요?
There was a problem hiding this comment.
해당 메서드는 Sales가 생성되는 것을 테스트하므로 예외를 던지지 않는다 + Null이 아니다를 합쳐서 isNotNull을 사용했습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 구현 설명
중복된 엔티티 객체 생성 코드 static 메서드로 분리
✅ 피드백 반영사항
이전 PR의 리뷰 사항 반영