[POM-94] 가게 이미지 업로드 기능 추가 #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juno-junho
requested review from
hyeon-z,
choi5798,
beomukim,
Juhongseok and
ddongpuri
and removed request for
hyeon-z and
choi5798
ddongpuri
approved these changes
Sep 17, 2023
src/main/java/com/ray/pominowner/store/controller/StoreController.java
Outdated
Show resolved
Hide resolved
hyeon-z
approved these changes
Sep 18, 2023
| @Entity | ||
| @EqualsAndHashCode(of = "id") |
There was a problem hiding this comment.
BaseTimeEntity를 상속하고 있으니 callSuper = false 해당 부분을 추가하면 좋을 것 같습니다!
There was a problem hiding this comment.
callsuper = false는 default라 명시 안했어요
Juhongseok
reviewed
Sep 18, 2023
src/main/java/com/ray/pominowner/store/service/StoreImageService.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 설명
기능은 MultipartFile로 이미지 리스트를 받으면, 사용자가 전송한 이미지의 이름, 이미지 이름에서 확장자만 떼어
UUID + 확장자이름으로 application-dev.yml에 설정한 경로에 저장합니다.따라서 StoreImage 엔티티에서는 경로, 원본 이미지 이름, 저장하는 이미지 이름(uuid)로 관리합니다.
참고
지난 pr시 이름 수정, 양방향 매핑, 자잘한 디렉토리 생성 및 application-dev.yml 설정 수정 등으로 file Changed 수가 좀 많습니다.
여러 파일에서 조금씩 수정하였고, 메인은 StoreImage 엔티티와 StoreImageService입니다.
다음부터 좀 더 잘게 PR을 나눠볼게요