Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract infinite loading functions from Bea Theme #22

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

riffbyte
Copy link
Contributor

No description provided.

@riffbyte riffbyte requested a review from kudlajz April 12, 2022 13:23
@riffbyte riffbyte self-assigned this Apr 12, 2022
@linear
Copy link

linear bot commented Apr 12, 2022

TF-666 Extract Infinite loading logic into `theme-kit-nextjs`

The only issue with extracting the logic is its dependency on presence of /api routes that it fetches.

But, this can be remedied by providing the necessary documentation with code examples, also the actual handlers for the API routes can be easily extracted.

One key feature that needs to be configurable is the include parameter for stories, but otherwise should be pretty straightforward.

Base automatically changed from feature/tf-667-extract-sitemap-generator-to-theme-kit to main April 12, 2022 13:33
@riffbyte riffbyte merged commit d9cae23 into main Apr 12, 2022
@riffbyte riffbyte deleted the feature/tf-666-extract-infinite-loading-logic branch April 12, 2022 13:33
e1himself pushed a commit that referenced this pull request Oct 17, 2023
…policy-text-under

[TITS-5039] Changed subscription disclaimer message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants