-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid errors when linting Vue.js SFCs. #18
Comments
@jpickwell - have you resolved this? Can you check out #19 - it seems I am having a similar issue. |
@khrome83, no I have not solved this. I'm now using Prettier v1.17.0 and Stylelint v10.0.1. I'm still experiencing this issue. |
I pretty much have the same problems.
If you do replace that transforming the code to
You get Replace This is on
|
#18 offers a reproduction in plain css that suggests it isn't the scss lang being a pain
|
Hi @jpickwell, @khrome83 and @dmnrmr, Thank you for putting up with my silence over the past few weeks (ok fine 2 months). Life got a bit hectic for a while there :) Unfortunatly stylelint's css-in-js stuff is pretty opaque to me as I've never used it. Would one of you be able to set up a repo that reproduces this issue that I can clone and go into debugging it without wondering how to setup the css-in-js stuff? |
This does seem to be related to |
@dmnrmr, thanks that was exactly what I was after and allowed me to find the root cause pretty quickly. #22 will fix this. I've just published v1.1.0 which contains that PR. Basically the issue was stylelint 9.10.x changed how vue files got passed into rules, which meant stylelint-prettier run prettier's vue parser over a block of CSS. While I could make it format the chunks of the file using prettier it doesn't actually feel worth it - it'll only prettify the contents of your |
What version of
stylelint
,prettier
andstylelint-prettier
are you using?prettier: 1.16.3
stylelint: 9.10.1
stylelint-config-prettier: 5.0.0
stylelint-prettier: 1.0.6
Please paste any applicable config files that you're using (e.g.
.prettierrc
or.stylelintrc
files)What source code are you linting?
What did you expect to happen?
No errors.
What actually happened?
The text was updated successfully, but these errors were encountered: