-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow clients to access messages from eslint #827
Conversation
🦋 Changeset detectedLatest commit: 1e1901b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I expect that given that this PR adds a new export, it should have a changeset. So I clicked on the link about how to add a changeset, and I tried |
@gwhitney To create a changeset, the command should be |
Thanks! Now it reports |
@gwhitney If you want you can add me to as a contributor to your forked repo and I'll make a PR to put the changeset in |
I'm confused? I've already allowed edits by maintainers... |
I am still confused, why do you need access to the entire fork as opposed to this branch on the fork, which you presumably already have? That was my question, sorry I wasn't clear... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #827 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 291 301 +10
Branches 82 83 +1
=========================================
+ Hits 291 301 +10 ☔ View full report in Codecov by Sentry. |
Thanks so much for doing that for me! I really appreciate it. |
Stale pull request |
I see the stale marking; is there anything I am supposed to be doing to advance this? Thanks for letting me know. |
Why was this closed? Was it deemed not desirable for the project? Or would some different approach to issue #704 be preferred? Please let me know what I can do to work toward a solution for that issue. Thanks! |
Well, the stale bot is stupid in this case... |
@gwhitney Do you have anytime to fix the conflicts? |
Hope to later today, not 100% certain. Will keep you posted. |
Adds another export `analyze` from this package, which behaves exactly like `format` except that it returns a simple object with properties `output` giving the formatted text and `messages` giving the eslint messages produced in processing the input text. Clients can call `analyze` instead of `format` if they wish, for example, to capture any errors that esling may have encountered. Resolves prettier#704.
19c671f
to
1e1901b
Compare
OK, did my best to rebase. The new test runs OK on my machine. Let me know what else I can do to help. Thanks! |
I don't see anything strange, so merging. |
Adds another export
analyze
from this package, which behavesexactly like
format
except that it returns a simple objectwith properties
output
giving the formatted text andmessages
giving the eslint messages produced in processing the input text.
Clients can call
analyze
instead offormat
if they wish, forexample, to capture any errors that eslint may have encountered.
Resolves #704.